Docs: nest: bringing nest doc to basic style guidelines #1476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lynette Miles <[email protected]>
Signed-off-by: Lynette Miles <[email protected]>
cnorris-cs
reviewed
Oct 18, 2024
cnorris-cs
reviewed
Oct 18, 2024
cnorris-cs
reviewed
Oct 18, 2024
Comment on lines
+90
to
+91
| Using command line mode requires quotes to parse the wildcard properly. The use | ||
| of a configuration file is recommended. |
Contributor
There was a problem hiding this comment.
I'm not saying we should use a note here, but while we should be removing instances of "Please note" or "Note", we do also have a note alert box element that we can use wherever it can provide value. Again, this may or may not be a place for the note alert box, but I just wanted to mention its existence for potential use.
cnorris-cs
approved these changes
Oct 18, 2024
Contributor
cnorris-cs
left a comment
cnorris-cs
left a comment
There was a problem hiding this comment.
I left comments and suggestions, but I've added my approval based on those to keep this moving.
Co-authored-by: Craig Norris <[email protected]> Signed-off-by: esmerel <[email protected]>
esmerel
deleted the
lynettemiles/sc-113441/update-pipeline-filters-nest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.